Replace private/public macro hacks in waylib with explicit member accessors#873
Replace private/public macro hacks in waylib with explicit member accessors#873Copilot wants to merge 2 commits into
private/public macro hacks in waylib with explicit member accessors#873Conversation
Agent-Logs-Url: https://github.com/linuxdeepin/treeland/sessions/b6871d44-d142-406b-9b22-4e1c645ded78 Co-authored-by: zccrs <13449038+zccrs@users.noreply.github.com>
Agent-Logs-Url: https://github.com/linuxdeepin/treeland/sessions/b6871d44-d142-406b-9b22-4e1c645ded78 Co-authored-by: zccrs <13449038+zccrs@users.noreply.github.com>
There was a problem hiding this comment.
Sorry @Copilot, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Copilot. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
TAG Bot New tag: 0.8.7 |
|
已解决,这个pr不需要了 |
This change removes the
#define private public/#define protected publicpattern used inwaylib/src/server, which can silently alter unrelated declarations and make Qt private-header usage brittle. The refactor keeps the existing access points but moves them to a scoped, explicit mechanism.Accessor mechanism
waylib/src/server/utils/memberaccessor_p.hcpp-member-accessorQt/QtQuick private access cleanup
kernel/wcursor.cppkernel/wserver.cppqtquick/wqmlcreator.cppqtquick/woutputrenderwindow.cppqtquick/private/wqmlhelper.cppqtquick/private/wbufferrenderer.cppqtquick/private/wrenderbuffernode.cppprivate/protected -> publicmacro blocks from these files and related headersQPA screen handling
QScreenprivate-constructor access inplatformplugin/qwlrootsintegration.cppQScreenwrapper throughQWindowSystemInterface::handleScreenAdded()and then detach it fromQGuiApplication::screens()to preserve the previous behavior without using the private constructor directlySurface area reduction
qwlrootsintegration.h,wqmlhelper_p.h, andwbufferrenderer_p.hExample of the new pattern: