chore: bump version to 0.8.7#886
Merged
Merged
Conversation
|
TAG Bot TAG: 0.8.7 |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates project and protocol dependency versions to 0.8.7 / 0.5.7 and refreshes Debian packaging metadata accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
src/modules/foreign-toplevel/CMakeLists.txt, thefind_package(TreelandProtocols REQUIRED 0.5.7)arguments are in the wrong order for CMake; the version should precedeREQUIRED(i.e.,find_package(TreelandProtocols 0.5.7 REQUIRED)). - The PR title and
find_packagechange reference version 0.5.7 while the top-level project version is bumped to 0.8.7; consider clarifying or aligning these version numbers to avoid confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `src/modules/foreign-toplevel/CMakeLists.txt`, the `find_package(TreelandProtocols REQUIRED 0.5.7)` arguments are in the wrong order for CMake; the version should precede `REQUIRED` (i.e., `find_package(TreelandProtocols 0.5.7 REQUIRED)`).
- The PR title and `find_package` change reference version 0.5.7 while the top-level project version is bumped to 0.8.7; consider clarifying or aligning these version numbers to avoid confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Log: new tag
zccrs
approved these changes
May 22, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wineee, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot ✅ Tag created successfully 📋 Tag Details
|
This was referenced May 22, 2026
Open
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: new tag
Summary by Sourcery
Bump the core project version and tighten the TreelandProtocols dependency to the new 0.5.7 release.
Build: