Fix entryLocale validation code
#6
Conversation
|
Previously, |
src/desktopfilereader.cpp
Outdated
| (c >= 'a' && c <= 'z') || | ||
| (c == '_') || (c == '@') | ||
| (c == '_') || (c == '@') || | ||
| (c == '[') || (c == ']') |
There was a problem hiding this comment.
This permits the use of [ characters inside the locale part. I think you should remove this line, and iterate over the inner part only.
There was a problem hiding this comment.
Actually, no, this is handled elsewhere already. However, I find it confusing to permit these here. I am going to update your branch to iterate only over the inner part of the string.
|
We need to add a test case to make sure this won't happen again in the future. |
|
Seems like the existing check is already pretty broken. We have a test that is failing already on a locale like |
2 participants
No description provided.