Skip to content

Bug fixes for filter ranges#1037

Merged
gaspergrom merged 1 commit intomainfrom
bugfix/filters-between
Jun 26, 2023
Merged

Bug fixes for filter ranges#1037
gaspergrom merged 1 commit intomainfrom
bugfix/filters-between

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Jun 26, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 00f22e0

This pull request updates the label rendering and query parsing logic for the number and date filter components in the frontend. It adds support for the FilterNumberOperator.NOT_BETWEEN and FilterDateOperator.NOT_BETWEEN operators, and improves the clarity and consistency of the labels.

🤖 Generated by Copilot at 00f22e0

BETWEEN or not
Filtering by date or number
Autumn leaves the valueTo

Why

How

🤖 Generated by Copilot at 00f22e0

  • Support the FilterDateOperator.NOT_BETWEEN and FilterNumberOperator.NOT_BETWEEN operators for the date and number filter components in the frontend (link, link, link)
  • Modify the numberItemLabelRenderer function in number.label.renderer.ts to prepend the operand text to the value text for the FilterNumberOperator.NOT_BETWEEN operator and remove it for the FilterNumberOperator.BETWEEN operator (link)
  • Modify the dateQueryUrlParser and numberQueryUrlParser functions in date.parser.ts and number.parser.ts to check for both the BETWEEN and NOT_BETWEEN operators when parsing the value from the query string or deleting the valueTo property from the filter object (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Jun 26, 2023
@gaspergrom gaspergrom requested a review from joanagmaia June 26, 2023 16:16
@gaspergrom gaspergrom self-assigned this Jun 26, 2023
@gaspergrom gaspergrom merged commit 5b235d4 into main Jun 26, 2023
@gaspergrom gaspergrom deleted the bugfix/filters-between branch June 26, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants