Bug fixes for filter ranges#1037
Merged
gaspergrom merged 1 commit intomainfrom Jun 26, 2023
Merged
Conversation
joanagmaia
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 00f22e0
This pull request updates the label rendering and query parsing logic for the number and date filter components in the frontend. It adds support for the
FilterNumberOperator.NOT_BETWEENandFilterDateOperator.NOT_BETWEENoperators, and improves the clarity and consistency of the labels.
🤖 Generated by Copilot at 00f22e0
Why
How
🤖 Generated by Copilot at 00f22e0
FilterDateOperator.NOT_BETWEENandFilterNumberOperator.NOT_BETWEENoperators for the date and number filter components in the frontend (link, link, link)numberItemLabelRendererfunction innumber.label.renderer.tsto prepend the operand text to the value text for theFilterNumberOperator.NOT_BETWEENoperator and remove it for theFilterNumberOperator.BETWEENoperator (link)dateQueryUrlParserandnumberQueryUrlParserfunctions indate.parser.tsandnumber.parser.tsto check for both theBETWEENandNOT_BETWEENoperators when parsing the value from the query string or deleting thevalueToproperty from the filter object (link, link)Checklist ✅
Feature,Improvement, orBug.