Add fallback query to GitHub integration commits#1048
Merged
garrrikkotua merged 3 commits intomainfrom Jun 27, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at e49b595
This pull request improves the robustness and consistency of the Github integration service by adding a fallback query for pull request commits. The new query omits the
additionsfield, which can cause errors for large commits, and the service handles the missing data accordingly. The changes affect thebackend/src/serverless/integrationsfolder, mainly thegithubIntegrationService.tsandpullRequestCommitsNoAdditions.tsfiles.
copilot:poem
Why
How
🤖 Generated by Copilot at e49b595
PullRequestCommitsQueryNoAdditionsto fetch pull request commits without the additions field (link)GithubIntegrationService.fetchStream(link)parseActivitiesto accept both types of commit records and use zero as default for missing additions field (link, link)githubIntegrationService.ts(link)Checklist ✅
Feature,Improvement, orBug.