Clean up filters code#1082
Merged
joanagmaia merged 8 commits intomainfrom Jul 17, 2023
Merged
Conversation
gaspergrom
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 5ec9a72
This pull request refactors the activity module by removing unused code and dependencies, simplifying the logic and the state management, improving the performance and the user feedback, and fixing some bugs. It also enhances the filter components and the LinkedIn integration. The main files affected are
frontend/package-lock.json,frontend/package.json,frontend/src/modules/activity/*,frontend/src/assets/scss/filter.scss,frontend/src/integrations/linkedin/config.js.
🤖 Generated by Copilot at 5ec9a72
Why
How
🤖 Generated by Copilot at 5ec9a72
filesizepackage from project configuration and lock files (link, link, link, link)listmethod toqueryin activity service file (link)handleDestroymethod in activity dropdown component file to use activity service and display message (link)fetchActivitiesaction in activity Pinia store file to usequerymethod (link)filter.scssfile (link)urlfunction in LinkedIn integration configuration file to fix bug with undefined username (link)remotePopulateItemsfunction in member filter configuration file to uselistMembersmethod (link)Checklist ✅
Feature,Improvement, orBug.