Skip to content

Members organizations relationship time-dependent#1087

Merged
joanagmaia merged 10 commits intomainfrom
feature/members-organizations-relationship
Jul 12, 2023
Merged

Members organizations relationship time-dependent#1087
joanagmaia merged 10 commits intomainfrom
feature/members-organizations-relationship

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Jul 10, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 3df0f9d

The pull request adds a new feature to manage and display the organizations associated with a member. It introduces a new member-form-organizations component to edit organizations in the member form page, and a new member-aside-organizations component to show organizations in the member view page. It also removes the organization field from the member-form-details component and the work experience attribute from the member-view-aside-enriched component, as they are redundant with the new feature. It updates the member-form-attributes, member-form-identities, and member-organizations components to use a consistent grid layout and class binding. It modifies the autocomplete-one-input component to make it more flexible and prevent errors. It updates the member and organization types to include the new organization properties. It changes the organization-field map function to return the whole organization object and use the displayName property.

🤖 Generated by Copilot at 3df0f9d

member-form changes
adding organizations
autumn of refactor

Why

How

🤖 Generated by Copilot at 3df0f9d

  • Added a new component member-form-organizations.vue to display and edit the organizations associated with a member in the member form page (link, link, link, link)
  • Changed the grid layout of the member form components from 3 columns to 4 columns to accommodate the new organization field (link, link, link, link)
  • Changed the conditional class binding of the custom attributes and identities containers from 2 columns to 3 columns to match the new grid layout (link, link)
  • Removed the organization field from the member-form-details.vue component as it was moved to the new component and removed the unused imports and functions related to the organization service and the app avatar component (link, link, link)
  • Changed the member-organizations.vue component to display only the most recent or active organization of a member in both vertical and horizontal orientations and added a computed property to calculate the active organization by comparing the start and end dates of the organizations (link, link, link, link, link, link)
  • Added a new component member-aside-organizations.vue to display the organizations associated with a member in the member view aside component and added a link to edit them in the member form page (link, link, link)
  • Removed the work experience attribute from the member-view-aside-enriched.vue component as it was replaced by the new component (link)
  • Changed the organization type to include the title, startDate, and endDate properties to store the job title and the period of the association with a member (link)
  • Changed the organization field to return the whole organization object instead of just the id and name and to use the displayName property instead of the name property (link)
  • Changed the member type to use the organization type instead of any type for the organizations property (link, link)
  • Changed the autocomplete one input component to use the clearable prop of the parent component instead of always being true and to check the query instead of the value for creating a new item to prevent duplicates (link, link, link)
  • Added a console log statement to the member form page component to debug the organizations value of the form model (link)
  • Removed some empty lines from the autocomplete one input component for code formatting (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Feature Created by Linear-GitHub Sync label Jul 10, 2023
@joanagmaia joanagmaia requested a review from gaspergrom July 10, 2023 08:56
@joanagmaia joanagmaia self-assigned this Jul 10, 2023
@joanagmaia joanagmaia force-pushed the feature/members-organizations-relationship branch 2 times, most recently from ed9be99 to 5a5b48b Compare July 10, 2023 11:32
@joanagmaia joanagmaia force-pushed the feature/members-organizations-relationship branch from 5a5b48b to ac96868 Compare July 10, 2023 12:40
@joanagmaia joanagmaia merged commit 8f79792 into main Jul 12, 2023
@joanagmaia joanagmaia deleted the feature/members-organizations-relationship branch July 12, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants