Skip to content

Check null values in the emails list when showing merge suggestion#1118

Merged
skwowet merged 2 commits intolinuxfoundation:mainfrom
skwowet:bugfix/mergeSuggestions
Jul 13, 2023
Merged

Check null values in the emails list when showing merge suggestion#1118
skwowet merged 2 commits intolinuxfoundation:mainfrom
skwowet:bugfix/mergeSuggestions

Conversation

@skwowet
Copy link
Copy Markdown
Collaborator

@skwowet skwowet commented Jul 13, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at fcdec9b

Fixed a bug in the member merge suggestions component that caused errors when displaying email links for members with missing or empty emails. Updated the filter condition in member-merge-suggestions-details.vue to handle null or undefined values.

🤖 Generated by Copilot at fcdec9b

filter checks email
no null or empty values
links render in fall

Why

How

🤖 Generated by Copilot at fcdec9b

  • Fix filter condition for member emails to avoid errors when rendering links (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet skwowet added the Bug Created by Linear-GitHub Sync label Jul 13, 2023
@skwowet skwowet requested a review from joanagmaia July 13, 2023 13:52
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@skwowet skwowet merged commit 8b2f03f into linuxfoundation:main Jul 13, 2023
@skwowet skwowet deleted the bugfix/mergeSuggestions branch July 13, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants