Skip to content

Fix broken bulkEditTags and refactor logic of the component#1137

Merged
skwowet merged 7 commits intolinuxfoundation:mainfrom
skwowet:bugfix/editTags
Jul 19, 2023
Merged

Fix broken bulkEditTags and refactor logic of the component#1137
skwowet merged 7 commits intolinuxfoundation:mainfrom
skwowet:bugfix/editTags

Conversation

@skwowet
Copy link
Copy Markdown
Collaborator

@skwowet skwowet commented Jul 18, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at ce43748

The pull request refactors the frontend code for bulk updating tags of members. It replaces the old AppMemberListBulkUpdateTags component with a new AppTagPopover component that uses a form schema and a member store. It also moves the tag-popover component to the member module and updates its logic. It comments out a redundant popover component in the member-list-table component and adds a TODO comment.

🤖 Generated by Copilot at ce43748

Sing, O Muse, of the cunning coder who changed the code of tags
And how he faced the bug that lurked in app-tag-popover
He commented out the faulty component, leaving a note for Joana
The wise-eyed daughter of Athena, who first had placed it there

Why

How

🤖 Generated by Copilot at ce43748

  • Move and rename tag-popover component from tag module to member module (link)
  • Replace app-member-list-bulk-update-tags component with app-tag-popover component in member-list-toolbar component (link, link)
  • Remove app-member-list-bulk-update-tags component file (link)
  • Comment out app-tag-popover component in member-list-table component and add TODO comment (link)
  • Refactor tag-popover component to handle bulk update of tags for selected members (link, link, link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet skwowet added Bug Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync labels Jul 18, 2023
@skwowet skwowet requested a review from joanagmaia July 18, 2023 18:08
@skwowet skwowet self-assigned this Jul 19, 2023
Comment thread frontend/src/modules/tag/components/tag-popover.vue Outdated
Comment thread frontend/src/modules/tag/components/tag-popover.vue Outdated
@joanagmaia
Copy link
Copy Markdown
Contributor

Also found 2 issues:

  • we are using tag-popover in member-view-header. Could you also update here so that it matches your refactor of tag-popover?
  • If a member already has associated tags when we open the modal they are not pre selected. Could you also take a look at this please?

@skwowet skwowet merged commit 02e382e into linuxfoundation:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants