Fix broken bulkEditTags and refactor logic of the component#1137
Merged
skwowet merged 7 commits intolinuxfoundation:mainfrom Jul 19, 2023
Merged
Fix broken bulkEditTags and refactor logic of the component#1137skwowet merged 7 commits intolinuxfoundation:mainfrom
bulkEditTags and refactor logic of the component#1137skwowet merged 7 commits intolinuxfoundation:mainfrom
Conversation
joanagmaia
reviewed
Jul 19, 2023
Contributor
|
Also found 2 issues:
|
joanagmaia
approved these changes
Jul 19, 2023
joanagmaia
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at ce43748
The pull request refactors the frontend code for bulk updating tags of members. It replaces the old
AppMemberListBulkUpdateTagscomponent with a newAppTagPopovercomponent that uses a form schema and a member store. It also moves thetag-popovercomponent to themembermodule and updates its logic. It comments out a redundant popover component in themember-list-tablecomponent and adds a TODO comment.
🤖 Generated by Copilot at ce43748
Why
How
🤖 Generated by Copilot at ce43748
tag-popovercomponent fromtagmodule tomembermodule (link)app-member-list-bulk-update-tagscomponent withapp-tag-popovercomponent inmember-list-toolbarcomponent (link, link)app-member-list-bulk-update-tagscomponent file (link)app-tag-popovercomponent inmember-list-tablecomponent and add TODO comment (link)tag-popovercomponent to handle bulk update of tags for selected members (link, link, link, link, link, link)Checklist ✅
Feature,Improvement, orBug.