Fix several undefined errors in incoming data in Github integration#1156
Merged
garrrikkotua merged 1 commit intomainfrom Jul 21, 2023
Merged
Fix several undefined errors in incoming data in Github integration#1156garrrikkotua merged 1 commit intomainfrom
garrrikkotua merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 8a12c48
Added optional chaining operators to some expressions in
githubIntegrationService.tsandactivityTypes.tsto handle missing or undefined fields in GitHub pull request events. Added a truthy check for thedomainvariable inmemberService.tsto prevent errors when finding organizations by email domains.
🤖 Generated by Copilot at 8a12c48
Why
How
🤖 Generated by Copilot at 8a12c48
record.actor.login,record.assignee.login, andactivity.parent.titleexpressions inGithubIntegrationServiceclass (link, link, link, link, link, link, link)domainvariable before callingorganizationService.findByUrlmethod inMemberServiceclass (link)Checklist ✅
Feature,Improvement, orBug.