Skip to content

Remove wildcards from replacements when searching segments by slug#1161

Merged
sausage-todd merged 1 commit intomainfrom
project-query-bugfix
Jul 21, 2023
Merged

Remove wildcards from replacements when searching segments by slug#1161
sausage-todd merged 1 commit intomainfrom
project-query-bugfix

Conversation

@sausage-todd
Copy link
Copy Markdown
Contributor

@sausage-todd sausage-todd commented Jul 21, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 5b2b365

Fixed a bug in the segmentRepository that affected segment queries by slug. Refactored the query parameters to use exact matches instead of wildcards.

🤖 Generated by Copilot at 5b2b365

No more false segments in the dark
We fixed the bug that tore us apart
We removed the wildcards from the slugs
We found the truth in the segmentRepository

Why

How

🤖 Generated by Copilot at 5b2b365

  • Remove wildcard characters from parent_slug and grandparent_slug parameters in findSegments method to fix bug where segments with similar slugs were returned (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@sausage-todd sausage-todd force-pushed the project-query-bugfix branch from 5b2b365 to 00941db Compare July 21, 2023 14:01
@sausage-todd sausage-todd changed the base branch from crowd-linux to main July 21, 2023 14:01
@sausage-todd sausage-todd force-pushed the project-query-bugfix branch from 00941db to 22aab51 Compare July 21, 2023 14:02
@sausage-todd sausage-todd merged commit 8621c39 into main Jul 21, 2023
@sausage-todd sausage-todd deleted the project-query-bugfix branch July 21, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant