Skip to content

Formbricks prevent sending empty data#1210

Merged
gaspergrom merged 1 commit intomainfrom
bugfix/formbrick-empty-data
Aug 3, 2023
Merged

Formbricks prevent sending empty data#1210
gaspergrom merged 1 commit intomainfrom
bugfix/formbrick-empty-data

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Aug 3, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 71d87c3

Improved formbricks integration in auth store by adding conditional checks. This fixes potential bugs with user attributes for feedback and analytics.

🤖 Generated by Copilot at 71d87c3

Oh we're the crew of the auth store
And we work with formbricks galore
We set the user attributes right
On the count of three, heave with all your might

Why

How

🤖 Generated by Copilot at 71d87c3

  • Add conditional checks before calling formbricks methods to set user attributes in state.currentUser (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Aug 3, 2023
@gaspergrom gaspergrom requested a review from joanagmaia August 3, 2023 07:20
@gaspergrom gaspergrom self-assigned this Aug 3, 2023
@gaspergrom gaspergrom merged commit 5de65cb into main Aug 3, 2023
@gaspergrom gaspergrom deleted the bugfix/formbrick-empty-data branch August 3, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants