Skip to content

Hubspot filter properties#1211

Merged
gaspergrom merged 3 commits intomainfrom
improvement/hubspot-search-property
Aug 3, 2023
Merged

Hubspot filter properties#1211
gaspergrom merged 3 commits intomainfrom
improvement/hubspot-search-property

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Aug 3, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 5d24a61

Improved HubSpot property mapping feature by adding a filterable option selector in hubspot-property-map.vue. Removed a redundant logging statement.

🤖 Generated by Copilot at 5d24a61

We're mapping properties with HubSpot, me hearties
We're adding filters to the option selector
But don't forget to clean up the logging statement
Or we'll have a mess in the code inspector

Why

How

🤖 Generated by Copilot at 5d24a61

  • Add filterable prop to v-select component to enable filtering HubSpot properties by input (link)
  • Remove console.log statement from handleInput method to avoid cluttering the browser console (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom requested a review from joanagmaia August 3, 2023 07:49
@gaspergrom gaspergrom self-assigned this Aug 3, 2023
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a console.log -> not sure if on purpose

@gaspergrom gaspergrom merged commit d49664f into main Aug 3, 2023
@gaspergrom gaspergrom deleted the improvement/hubspot-search-property branch August 3, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants