Skip to content

Fix Merge member action in members page#1217

Merged
joanagmaia merged 1 commit intomainfrom
bug/merge-member-members-page
Aug 7, 2023
Merged

Fix Merge member action in members page#1217
joanagmaia merged 1 commit intomainfrom
bug/merge-member-members-page

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Aug 4, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at a20013f

Added a feature to merge members from the member-view-header.vue component and cleaned up some unused or redundant code.

🤖 Generated by Copilot at a20013f

We're sailing on the Vue seas, me hearties
We're formatting and importing with care
We're merging members with a merge event
And we're opening a dialog in the air

Why

How

🤖 Generated by Copilot at a20013f

  • Emit and handle merge event to open merge dialog for members (link, link)
  • Add and render app-member-merge-dialog component to merge members (link, link, link)
  • Remove unused import of AppMemberMergeDialog from member-dropdown.vue (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Aug 4, 2023
@joanagmaia joanagmaia requested a review from gaspergrom August 4, 2023 08:31
@joanagmaia joanagmaia self-assigned this Aug 4, 2023
@joanagmaia joanagmaia merged commit 2e9dba3 into main Aug 7, 2023
@joanagmaia joanagmaia deleted the bug/merge-member-members-page branch August 7, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants