Skip to content

Organization page members fix#1227

Merged
gaspergrom merged 1 commit intomainfrom
bugfix/organization-members
Aug 7, 2023
Merged

Organization page members fix#1227
gaspergrom merged 1 commit intomainfrom
bugfix/organization-members

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Aug 7, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 668afc7

Improved reactivity of organization view components. Changed organization-view-page.vue to pass a reactive prop for the organization id to app-organization-view-members and app-activity-timeline.

🤖 Generated by Copilot at 668afc7

Oh we're the coders of the sea, and we work with props and data
We make our components smart and reactive, so they can handle any change
When the organizationId shifts in the route, we don't want to be left behind
So we heave away on the count of three, and update our app-organization-view-members and app-activity-timeline

Why

How

🤖 Generated by Copilot at 668afc7

  • Use props.id prop instead of organization.id data property in app-organization-view-members and app-activity-timeline components to make them reactive to route changes (link, link) in organization-view-page.vue

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom self-assigned this Aug 7, 2023
@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Aug 7, 2023
@gaspergrom gaspergrom merged commit e71afee into main Aug 7, 2023
@gaspergrom gaspergrom deleted the bugfix/organization-members branch August 7, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant