Skip to content

Fixed enrichment being removed from the quota when not found#1316

Merged
joanreyero merged 2 commits intomainfrom
bugfix/enrichment-when-not-found
Aug 10, 2023
Merged

Fixed enrichment being removed from the quota when not found#1316
joanreyero merged 2 commits intomainfrom
bugfix/enrichment-when-not-found

Conversation

@joanreyero
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero commented Aug 10, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 1d25ef9

Fix bug in memberEnrichmentService that could cause error with empty profiles. Add error handling and logging for this case.

🤖 Generated by Copilot at 1d25ef9

No profile, no mercy, the API is a lie
memberEnrichmentService will make them cry
We check for falsy values, we don't let them pass
We throw an error

Why

How

🤖 Generated by Copilot at 1d25ef9

  • Prevent errors when Enrichment API returns empty profile object (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanreyero joanreyero merged commit 15cd715 into main Aug 10, 2023
@joanreyero joanreyero deleted the bugfix/enrichment-when-not-found branch August 10, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant