Skip to content

Improve member's organizations sorting#1335

Merged
sausage-todd merged 1 commit intomainfrom
sort-work-experience-hotfix
Aug 14, 2023
Merged

Improve member's organizations sorting#1335
sausage-todd merged 1 commit intomainfrom
sort-work-experience-hotfix

Conversation

@sausage-todd
Copy link
Copy Markdown
Contributor

@sausage-todd sausage-todd commented Aug 14, 2023

  1. Those without dateEnd, but with dateStart should be at the top, orderd by dateStart
  2. Those with dateEnd and dateStart should be in the middle, ordered by dateEnd
  3. Those without dateEnd and dateStart should be at the bottom, ordered by name

Changes proposed ✍️

What

🤖 Generated by Copilot at ea0a6fc

Modified the sortMembers method of the MemberRepository class to use a new sorting logic for the members based on their membership dates. This change improves the member sorting in the frontend as requested in issue #123.

🤖 Generated by Copilot at ea0a6fc

sortMembers changed
New logic for membership
Autumn leaves falling

Why

How

🤖 Generated by Copilot at ea0a6fc

  • Implement new sorting logic for members based on their membership dates (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

1. Those without dateEnd, but with dateStart should be at the top, orderd by dateStart
2. Those with dateEnd and dateStart should be in the middle, ordered by dateEnd
3. Those without dateEnd and dateStart should be at the bottom, ordered by name
@sausage-todd sausage-todd merged commit 44f576b into main Aug 14, 2023
@sausage-todd sausage-todd deleted the sort-work-experience-hotfix branch August 14, 2023 13:20
joanreyero pushed a commit that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant