Skip to content

Don't enrich organizations with 0 activities#1347

Merged
skwowet merged 1 commit intomainfrom
bugfix/organization-enrichment
Aug 16, 2023
Merged

Don't enrich organizations with 0 activities#1347
skwowet merged 1 commit intomainfrom
bugfix/organization-enrichment

Conversation

@skwowet
Copy link
Copy Markdown
Collaborator

@skwowet skwowet commented Aug 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 7ddce8b

This pull request adds a activityCount property to the IOrganization interface and the database query that selects organizations. It also modifies the organizationEnrichmentService to skip organizations that have no activities from the enrichment process. This improves the performance and accuracy of the enrichment process by avoiding unnecessary API calls and database updates.

🤖 Generated by Copilot at 7ddce8b

Skip orgs with none
activityCount filters
Winter of data

Why

How

🤖 Generated by Copilot at 7ddce8b

  • Add activityCount property to IOrganization interface to store the number of activities for each organization (link)
  • Modify query to select organizations from the database to include the activity."orgActivityCount" column and populate the activityCount property (link)
  • Skip organizations with zero activityCount from the enrichment process to avoid unnecessary API calls and database updates (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet skwowet added the Bug Created by Linear-GitHub Sync label Aug 16, 2023
@skwowet skwowet requested a review from joanreyero August 16, 2023 15:58
@skwowet skwowet changed the title Prevent organizations enrichments with 0 activities Don't enrich organizations with 0 activities Aug 16, 2023
@skwowet skwowet merged commit 7e6f457 into main Aug 16, 2023
@skwowet skwowet deleted the bugfix/organization-enrichment branch August 16, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant