Affiliations for past activities to orgs without dates#1353
Merged
sausage-todd merged 3 commits intomainfrom Aug 17, 2023
Merged
Affiliations for past activities to orgs without dates#1353sausage-todd merged 3 commits intomainfrom
sausage-todd merged 3 commits intomainfrom
Conversation
added 3 commits
August 17, 2023 12:51
This way we still affiliat past activities if we didn't have any dates for orgs for that period
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at dfc6d02
This pull request adds a new feature to get the most recent organization that a member has ever been affiliated with, regardless of whether the affiliation is current or past. It updates the
getAffiliationsandgetMostRecentOrganizationIdmethods of theMemberAffiliationRepositoryandMemberAffiliationServiceclasses in the backend and the data sink worker. It also adds a new methodfindMostRecentOrganizationEverto theMemberRepositoryandMemberAffiliationRepoclasses to query thememberOrganizationstable.
🤖 Generated by Copilot at dfc6d02
Why
How
🤖 Generated by Copilot at dfc6d02
findMostRecentOrganizationEvermethod to two repositories (link, link)getAffiliationsmethod of theMemberAffiliationRepositoryclass in thebackend(link)getAffiliationsmethod of theMemberAffiliationRepositoryclass in thebackendto fetch the past affiliations of a member (link)Checklist ✅
Feature,Improvement, orBug.