Skip to content

Affiliations for past activities to orgs without dates#1353

Merged
sausage-todd merged 3 commits intomainfrom
affiliations-to-no-dates-org
Aug 17, 2023
Merged

Affiliations for past activities to orgs without dates#1353
sausage-todd merged 3 commits intomainfrom
affiliations-to-no-dates-org

Conversation

@sausage-todd
Copy link
Copy Markdown
Contributor

@sausage-todd sausage-todd commented Aug 17, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at dfc6d02

This pull request adds a new feature to get the most recent organization that a member has ever been affiliated with, regardless of whether the affiliation is current or past. It updates the getAffiliations and getMostRecentOrganizationId methods of the MemberAffiliationRepository and MemberAffiliationService classes in the backend and the data sink worker. It also adds a new method findMostRecentOrganizationEver to the MemberRepository and MemberAffiliationRepo classes to query the memberOrganizations table.

🤖 Generated by Copilot at dfc6d02

To find the most recent org ever
We added a method quite clever
It queries the table
And if it is able
Returns the org ID or null, whatever

Why

How

🤖 Generated by Copilot at dfc6d02

  • Add logic to get the most recent organization ID of a member, either current or past, in two services (link, link)
  • Add the findMostRecentOrganizationEver method to two repositories (link, link)
  • Add a condition to remove null values from the array of organization IDs returned by the getAffiliations method of the MemberAffiliationRepository class in the backend (link)
  • Add a join to the getAffiliations method of the MemberAffiliationRepository class in the backend to fetch the past affiliations of a member (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

Misha Savelyev added 3 commits August 17, 2023 12:51
@sausage-todd sausage-todd merged commit 46d92c4 into main Aug 17, 2023
@sausage-todd sausage-todd deleted the affiliations-to-no-dates-org branch August 17, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant