Fix auto assign member to existing organization based on email domain#1363
Merged
Fix auto assign member to existing organization based on email domain#1363
Conversation
garrrikkotua
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 7927475
Implemented the auto-assignment feature for members and organizations. Added a new method
findByDomainto theorganizationRepositoryandorganizationServiceclasses to query organizations by email domain. Refactored thememberServiceclass to use the new method and assign members to organizations accordingly.
🤖 Generated by Copilot at 7927475
Why
How
🤖 Generated by Copilot at 7927475
findByDomaininorganizationRepository.tsthat queries the database for an organization with a matching website attribute (link)findByDomainmethod inmemberService.tsto find and assign the organization ID to the member data (link)findByDomaininorganizationService.tsthat delegates the query to the repository layer (link)organizationsarray inmemberService.tsto improve readability and structure (link)Checklist ✅
Feature,Improvement, orBug.