Avoid exceeding max byte length during OpenSearch member indexing#1367
Merged
Avoid exceeding max byte length during OpenSearch member indexing#1367
Conversation
sausage-todd
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 977cacf
Refactored and added a common utility function for string truncation to the
@crowd/commonpackage. This function is used to trim strings that exceed a byte length limit for OpenSearch indexing in various services. Updated the imports and usage of the function inaws.ts,member.sync.service.ts, andsentiment.ts.
🤖 Generated by Copilot at 977cacf
Why
How
🤖 Generated by Copilot at 977cacf
trimUtf8ToMaxByteLengthfunction to@crowd/commonpackage to avoid duplication and improve reusability (link, link)trimUtf8ToMaxByteLengthfunction from@crowd/commonpackage inaws.ts,member.sync.service.ts, andsentiment.tsto truncate strings that exceed OpenSearch byte length limit (link, link, link)byteLength.tsfile from@crowd/commonpackage inindex.tsto allow other modules to accesstrimUtf8ToMaxByteLengthfunction (link)maxByteLengthconstant toMemberSyncServiceclass inmember.sync.service.tsto define OpenSearch byte length limit for string attributes (link)trimUtf8ToMaxByteLengthfunction to data of special attribute and value of string attribute inmember.sync.service.tsto avoid OpenSearch indexing errors (link, link)Checklist ✅
Feature,Improvement, orBug.