Fix email column inconsistencies in members list#1479
Merged
joanagmaia merged 4 commits intolinuxfoundation:mainfrom Sep 19, 2023
Merged
Fix email column inconsistencies in members list#1479joanagmaia merged 4 commits intolinuxfoundation:mainfrom
joanagmaia merged 4 commits intolinuxfoundation:mainfrom
Conversation
Contributor
Author
|
@yeganathan18 please take a look :) |
Collaborator
|
@peoray Looks good to me, It would be great if you could attach a screenshot, just to ensure everything is good on UI 🙂 |
joanagmaia
requested changes
Sep 13, 2023
| </template> | ||
| <div class="flex flex-wrap gap-3 my-1"> | ||
| <el-tooltip | ||
| v-for="email of scope.row.emails" |
Contributor
There was a problem hiding this comment.
I think Nuno's image might have induced an error, but the goal inside the popover is that it only displays the emails that are not visible on this list.
So let's say you have 5 emails. On the list it should display 3 and on the popover it should show the remaining 2 (that's why there's the +2 tag to indicate that 😄 )
Contributor
Author
There was a problem hiding this comment.
got that 👍🏽 , will make the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
Fixes #1164
🤖 Generated by Copilot at dd328ab
Improved the UI and functionality of the member list table component in
member-list-table.vue. Fixed a bug with an import statement.
🤖 Generated by Copilot at dd328ab
Why
How
🤖 Generated by Copilot at dd328ab
storeToRefsfunction (link)Checklist ✅
Feature,Improvement, orBug.