Skip to content

Removing redundant last activity plain in weekly emails conversations #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epipav merged 10 commits into from
Nov 4, 2022
Merged

Removing redundant last activity plain in weekly emails conversations #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7c8ecec
Fix EagleEye keyword filter (#9)
Aug 26, 2022
f8ba553
Weekly analytics emails for all workspace users (#10)
epipav Aug 28, 2022
b75e08a
removed unnecessary emailVerified double check
anilbostancii Aug 29, 2022
c52249e
aws access key/secret can't be empty string
epipav Aug 29, 2022
c2bb4bd
Merge branch 'main' of github.com:CrowdDotDev/crowd.dev into main
epipav Sep 2, 2022
4af5d54
Merge branch 'main' of github.com:CrowdDotDev/crowd.dev into main
epipav Oct 31, 2022
69be63a
Merge branch 'main' of github.com:CrowdDotDev/crowd.dev into main
epipav Nov 1, 2022
984c5ec
Merge branch 'main' of github.com:CrowdDotDev/crowd.dev into main
epipav Nov 1, 2022
1fb56bb
Merge branch 'main' of github.com:CrowdDotDev/crowd.dev into main
epipav Nov 1, 2022
ca617ab
cube endpoint updated on local, lastActivity redundant plain conversi…
epipav Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/.env.dist.composed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ CROWD_DB_WRITE_HOST="db"
CROWD_SEARCH_ENGINE_HOST="http://search-engine:7700"

# CubeJS settings
CROWD_CUBEJS_URL="http://cubejs:4000"
CROWD_CUBEJS_URL="http://cubejs:4000/cubejs-api/v1"
2 changes: 1 addition & 1 deletion backend/.env.dist.local
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ CROWD_DB_PASSWORD=example
CROWD_DB_DATABASE=crowd-web

# CubeJS settings
CROWD_CUBEJS_URL=http://localhost:4000
CROWD_CUBEJS_URL=http://localhost:4000/cubejs-api/v1
CROWD_CUBEJS_JWT_SECRET=137ea167812145c6d77452a58d7dd29b
CROWD_CUBEJS_JWT_EXPIRY=2h

Expand Down
6 changes: 3 additions & 3 deletions backend/src/serverless/microservices/nodejs/analytics/workers/weeklyAnalyticsEmailsWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ async function weeklyAnalyticsEmailsWorker(tenantId: string): Promise<AnalyticsE
c.platformPretty = platformDisplayNames[c.platform]

const conversationLazyLoaded = await conversationService.findById(c.id)
const lastActivity =

c.lastActivity =
conversationLazyLoaded.activities[conversationLazyLoaded.activities.length - 1]
c.lastActivity = lastActivity.get({ plain: true })
c.lastActivity.username = lastActivity.member.username[c.platform]
c.lastActivity.username = c.lastActivity.member.username[c.platform]

if (c.lastActivity.body) {
c.lastActivity.body = convertHtmlToText(c.lastActivity.body)
Expand Down