Skip to content

Check email domain is not undefined when assigning orgs#1637

Merged
garrrikkotua merged 1 commit intomainfrom
fix/check-domain-is-not-undefined
Oct 6, 2023
Merged

Check email domain is not undefined when assigning orgs#1637
garrrikkotua merged 1 commit intomainfrom
fix/check-domain-is-not-undefined

Conversation

@garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 6, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 43876a2

Fixed a bug in member.service.ts that could cause an error when processing invalid emails. Improved the email domain analysis logic for the data sink worker service.

🤖 Generated by Copilot at 43876a2

isDomainExcluded
Check before calling, avoid
Error in winter

Why

How

🤖 Generated by Copilot at 43876a2

  • Fix potential error when email is invalid or does not contain a domain (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 1de48a1 into main Oct 6, 2023
@garrrikkotua garrrikkotua deleted the fix/check-domain-is-not-undefined branch October 6, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant