Skip to content

Fix filters display and no results found state on members#164

Merged
joanagmaia merged 1 commit intomainfrom
bug/display-filters-empty-state-members
Nov 2, 2022
Merged

Fix filters display and no results found state on members#164
joanagmaia merged 1 commit intomainfrom
bug/display-filters-empty-state-members

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Fix display of filters in members page with sample data
  • Fix display of empty state when no search results with sample data
  • Screenshots (front-end changes only)

      - ...  
    

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 2, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 1e5f338
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/6362b5124de43a00081e7258

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 2, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 1e5f338
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/6362b5128bdacd00084c7dd9

Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 it

@joanagmaia joanagmaia merged commit 2295a93 into main Nov 2, 2022
@joanagmaia joanagmaia deleted the bug/display-filters-empty-state-members branch November 2, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants