Skip to content

Fix missing counter and paginator in Community Help Center page#167

Merged
joanagmaia merged 1 commit intomainfrom
bug/missing-counter-paginator
Nov 3, 2022
Merged

Fix missing counter and paginator in Community Help Center page#167
joanagmaia merged 1 commit intomainfrom
bug/missing-counter-paginator

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Fix pluralization of list counter. Use pluralize package to pluralize or singularize a word based on the passed in count:
    • @param word — The word to pluralize
    • @param count — How many of the word exist
    • @param inclusive — Whether to prefix with the number (e.g. 3 ducks)
  • Add app-pagination-sorter to Community help center page to change pagination size on sorter change
  • Add emit handler to app-pagination-sorter on Reports page to change pagination size on sorter change
  • Screenshots (front-end changes only)

Screenshot 2022-11-03 at 14 10 33

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 3, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 5905390
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/6363cc986ac99600086be7b0

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 3, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 5905390
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/6363cc984bf52d0008ef337d

@joanagmaia joanagmaia requested a review from mariobalca November 3, 2022 14:14
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing these! Looks good to me 🚢 it

@joanagmaia joanagmaia merged commit 4d6d8ba into main Nov 3, 2022
@joanagmaia joanagmaia deleted the bug/missing-counter-paginator branch November 3, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants