Skip to content

Fix reach column on members list#169

Merged
joanagmaia merged 1 commit intomainfrom
bug/reach-column-members-list
Nov 3, 2022
Merged

Fix reach column on members list#169
joanagmaia merged 1 commit intomainfrom
bug/reach-column-members-list

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • On member list, pass the reach value in the same format as on the member profile to match the logic on member-reach.vue
  • Protect formatNumberToCompact from non numbers
  • Screenshots (front-end changes only)

      - ...  
    

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 3, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 23cdfc6
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/636404ddeeb2330008b5678e

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 3, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 23cdfc6
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/636404dd87488e00084dfbf6

Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!
Let's merge it and deploy to staging as well 👍

@joanagmaia joanagmaia merged commit dfce746 into main Nov 3, 2022
@joanagmaia joanagmaia deleted the bug/reach-column-members-list branch November 3, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants