Skip to content

Fix minor style issues and platform component#178

Merged
mariobalca merged 3 commits intomainfrom
bug/style-issues
Nov 7, 2022
Merged

Fix minor style issues and platform component#178
mariobalca merged 3 commits intomainfrom
bug/style-issues

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Nov 7, 2022

Changes proposed ✍️

  • Fix margin around Profile title in Profile page - Task
  • Fix cursor pointer in users list - Task
  • Fix platform/channels icons in Community Help Center - Task
    • Made a reusable component for platform
    • Use component throughout application
  • Screenshots (front-end changes only)

Screenshot 2022-11-07 at 13 17 57
Screenshot 2022-11-07 at 13 18 36
Screenshot 2022-11-07 at 13 18 45

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 7, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit c34743c
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/6369441ae1a7d7000859431e

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 7, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit c34743c
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/6369441aceeec10008217b17

@joanagmaia joanagmaia requested a review from mariobalca November 7, 2022 13:21
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments/questions, that I'd like for us to discuss before merging.
Other than that, awesome work as always!

</el-button>
</div>
<div class="app-list-table panel">
<div class="user-list-table panel">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea with app-list-table was to have a generic CSS class.
Can we not use it on this user-list-table.vue component?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. I didn't remove it, I used the app-list-table class but added an extra class to prevent the style I wanted.

I added non-clickable class; if present, the row on hover won't have the cursor pointer

<div class="flex gap-3 items-center">
<app-platform
:platform="platform"
:platform-name="`${platform}-icon`"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't platform-name be a readable name like GitHub or StackOverflow?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I was using platform-name for both the tracking event names and the alt property of the images it didn't have to be readable. But to prevent errors and confusion I removed this prop and added one for the track events:
trackEventName, if passed we will track the clicks

For the alt property, I'm now just getting the name value of the integrations json from the platform value

@mariobalca
Copy link
Copy Markdown
Contributor

Perfect! Thanks for addressing my comments
Merging and deploying to staging

@mariobalca mariobalca merged commit 049f4cb into main Nov 7, 2022
@mariobalca mariobalca deleted the bug/style-issues branch November 7, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants