Skip to content

Fix copy public url in CHC#179

Merged
mariobalca merged 1 commit intomainfrom
bug/copy-public-url-chc
Nov 7, 2022
Merged

Fix copy public url in CHC#179
mariobalca merged 1 commit intomainfrom
bug/copy-public-url-chc

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

Task: Copy public URL for published conversations not working

Steps to reproduce:

  1. Community Help Center: When clicking on "Copy public URL" in published conversations, nothing happens
  2. In the console, an error is being thrown: Cannot read properties of undefined (reading 'slug')

Fix:

  • The slug was being used from an inexistent record. Get the slug from the conversation passed in the component
  • Screenshots (front-end changes only)

Screenshot 2022-11-07 at 14 35 05

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 7, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 7e53e7f
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/636917d8f51b890009094c1b

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 7, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 7e53e7f
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/636917d8fee7ab0009db7377

Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Will merge 👍

@mariobalca mariobalca merged commit 3f3b52c into main Nov 7, 2022
@mariobalca mariobalca deleted the bug/copy-public-url-chc branch November 7, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants