Skip to content

Fix reset view in Community Help Center and other modules#183

Merged
mariobalca merged 1 commit intomainfrom
bug/reset-view-chc
Nov 8, 2022
Merged

Fix reset view in Community Help Center and other modules#183
mariobalca merged 1 commit intomainfrom
bug/reset-view-chc

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Fix reset view in Community Help Center. It was previously calling the reset method in members store
  • Fix trackEventName default value in app-platform component. It is not required, console was throwing multiple warnings for when it was not being passed
  • Fix filter-type-search component to reset its value when store is also reseted.
    • Pass debounce/change method to @input handler instead of watching the value
    • Watch search value in store, if empty and different, set the input value to empty as well

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 8, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 6241ade
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/636a49c413fef000080df687

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 8, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 6241ade
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/636a49c4524a490009ae8b40

Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these 🙏
Will merge and deploy

@mariobalca mariobalca merged commit 1018467 into main Nov 8, 2022
@mariobalca mariobalca deleted the bug/reset-view-chc branch November 8, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants