Fix signin regex validation#1850
Merged
joanreyero merged 2 commits intomainfrom Nov 19, 2023
Merged
Conversation
Co-authored-by: Gasper Grom <gasper.grom@gmail.com> Co-authored-by: Joana Maia <joana@crowd.dev> (cherry picked from commit 08bf721)
joanreyero
approved these changes
Nov 19, 2023
sausage-todd
pushed a commit
that referenced
this pull request
Dec 7, 2023
Co-authored-by: Joan Reyero <joan@crowd.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖[deprecated] Generated by Copilot at 9b4bcb6
This pull request enhances the security, usability, and performance of the user, tenant, and report features in the backend and frontend. It adds password validation, permission checks, and a new tenantFindName endpoint. It also fixes a typo and improves the error messages for signing in and signing up. It affects the files
backend/src/database/repositories/userRepository.ts,backend/src/security/permissions.ts,backend/src/api/tenant/*,backend/src/services/auth/authService.ts,backend/src/i18n/en.ts,frontend/src/modules/auth/pages/*,frontend/src/modules/layout/components/menu/workspace/menu-workspace-popover.vue,frontend/src/modules/layout/config/links/*,frontend/src/modules/report/pages/report-view-page-public.vue,frontend/src/modules/tenant/tenant-service.js,frontend/src/modules/user/user-model.js, andfrontend/src/i18n/en.js.
🤖[deprecated] Generated by Copilot at 9b4bcb6
Why
How
🤖[deprecated] Generated by Copilot at 9b4bcb6
backend/src/i18n/en.tsandfrontend/src/i18n/en.jsmodules (link, link)frontend/src/i18n/en.jsmodule (link)Checklist ✅
Feature,Improvement, orBug.