Add retry wrapper to all discord endpoints#1857
Merged
garrrikkotua merged 1 commit intomainfrom Nov 20, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖[deprecated] Generated by Copilot at d44144d
This pull request improves the Discord integration by adding retry logic to handle rate limit errors from the Discord API. It refactors several functions in the
integrations/discord/apidirectory to use theretryWrapperfunction from thehandleRateLimitmodule. It also defines a customRateLimitErrorclass to distinguish rate limit errors from other types of errors.
🤖[deprecated] Generated by Copilot at d44144d
Why
How
🤖[deprecated] Generated by Copilot at d44144d
retryWrapperfunction to handle rate limit errors from Discord API (link)retryWrapperfunction and use it to wrap API calls ingetChannel,getChannels,getMember,getMembers,getMessage,getMessages, andgetThreadsfunctions (link, link, link, link, link, link, link, link, link, link, link, link, link, link)RateLimitErrorclass from@crowd/typesand use it inhandleDiscordErrorandretryWrapperfunctions (link)Checklist ✅
Feature,Improvement, orBug.