Skip to content

Fix empty drawer after publish conversation #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariobalca merged 1 commit into from
Nov 9, 2022
Merged

Fix empty drawer after publish conversation #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions frontend/src/premium/community-help-center/components/community-help-center-table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@
/>
</div>
</div>
<app-community-help-center-conversation-drawer
:expanded="drawerConversationId !== null"
:conversation-id="drawerConversationId"
@close="drawerConversationId = null"
></app-community-help-center-conversation-drawer>
</div>
</div>
</div>
Expand All @@ -206,13 +201,14 @@ import { useStore } from 'vuex'
import { formatDateToTimeAgo } from '@/utils/date'
import AppConversationDropdown from '@/modules/conversation/components/conversation-dropdown'
import AppCommunityHelpCenterToolbar from './community-help-center-toolbar'
import AppCommunityHelpCenterConversationDrawer from '@/premium/community-help-center/components/community-help-center-conversation-drawer'

const store = useStore()
defineEmits(['cta-click'])
const emit = defineEmits([
'cta-click',
'open-conversation-drawer'
])

const table = ref(null)
const drawerConversationId = ref(null)

const loading = computed(
() => store.state.communityHelpCenter.list.loading
Expand Down Expand Up @@ -311,7 +307,7 @@ function rowClass({ row }) {
}

function handleRowClick(row) {
drawerConversationId.value = row.id
emit('open-conversation-drawer', row.id)
}

function timeAgo(date) {
Expand Down
28 changes: 25 additions & 3 deletions frontend/src/premium/community-help-center/pages/community-help-center-page.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,15 @@
</div>
<app-community-help-center-tabs />
<app-community-help-center-filter />
<app-community-help-center-table />
<app-community-help-center-table
@open-conversation-drawer="onConversationDrawerOpen"
/>

<app-community-help-center-conversation-drawer
:expanded="!!drawerConversationId"
:conversation-id="drawerConversationId"
@close="onConversationDrawerClose"
></app-community-help-center-conversation-drawer>
</app-page-wrapper>
</template>

Expand All @@ -43,6 +51,7 @@ import AppCommunityHelpCenterTable from '@/premium/community-help-center/compone
import AppCommunityHelpCenterTabs from '@/premium/community-help-center/components/community-help-center-tabs'
import AppCommunityHelpCenterFilter from '@/premium/community-help-center/components/community-help-center-filter'
import AppCommunityHelpCenterSettings from '@/premium/community-help-center/components/community-help-center-settings'
import AppCommunityHelpCenterConversationDrawer from '@/premium/community-help-center/components/community-help-center-conversation-drawer'
import config from '@/config'

export default {
Expand All @@ -53,7 +62,14 @@ export default {
AppCommunityHelpCenterTable,
AppCommunityHelpCenterTabs,
AppCommunityHelpCenterFilter,
AppCommunityHelpCenterSettings
AppCommunityHelpCenterSettings,
AppCommunityHelpCenterConversationDrawer
},

data() {
return {
drawerConversationId: null
}
},

computed: {
Expand All @@ -78,7 +94,13 @@ export default {
'communityHelpCenter/doOpenSettingsDrawer',
doCloseSettingsDrawer:
'communityHelpCenter/doCloseSettingsDrawer'
})
}),
onConversationDrawerOpen(id) {
this.drawerConversationId = id
},
onConversationDrawerClose() {
this.drawerConversationId = null
}
}
}
</script>
Expand Down