Skip to content

Fix issue with load more in eagle eye#196

Merged
joanagmaia merged 1 commit intomainfrom
bug/eagle-eye-load-more
Nov 10, 2022
Merged

Fix issue with load more in eagle eye#196
joanagmaia merged 1 commit intomainfrom
bug/eagle-eye-load-more

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Refactor eagle eye page structure to match other pages (loading, counter/sorter, load more)
  • Fix the method being called when the load more button is clicked
  • Fix the getter from where the eagle eye pagination was being fetched
  • Clean the list of ids/rows, when there is a new fetch in eagle eye
  • Add the FETCH_STARTED mutation customization to eagle-eye mutations
  • Reset the active view pagination when the active tab changes

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 10, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 7c5488a
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/636ce5904230da00092ef220

@joanagmaia joanagmaia linked an issue Nov 10, 2022 that may be closed by this pull request
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 10, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 7c5488a
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/636ce590d657a8000967413b

Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this 🙏

@joanagmaia joanagmaia merged commit ad1ec22 into main Nov 10, 2022
@joanagmaia joanagmaia deleted the bug/eagle-eye-load-more branch November 10, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EagleEye load more shows the same content

2 participants