Skip to content

Delete unused modules, components and styles#211

Merged
mariobalca merged 1 commit intomainfrom
bug/delete-unused-modules
Nov 14, 2022
Merged

Delete unused modules, components and styles#211
mariobalca merged 1 commit intomainfrom
bug/delete-unused-modules

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

Issue:

  • Both audit-logs and plan are currently accessible in the application and shouldn't be. Both are deprecated and should be removed

Solution

  • Remove audit-log and plan modules
  • Remove filter components and styles no longer used

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 14, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit d62315c
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/637229f691962c00086a69a5

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 14, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit d62315c
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/637229f6ac4fc40008581b40

Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this housekeeping PR 🙏
We might need to revisit this one later, once we integrate with Striper (or another billing service), but I think we can safely remove these for now.
Will merge 🚢

@mariobalca mariobalca merged commit 063a709 into main Nov 14, 2022
@mariobalca mariobalca deleted the bug/delete-unused-modules branch November 14, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants