Skip to content

C-67: Fix labels in widget creation#221

Merged
mariobalca merged 1 commit intomainfrom
bug/c-67-labels-in-widget-creation
Nov 16, 2022
Merged

C-67: Fix labels in widget creation#221
mariobalca merged 1 commit intomainfrom
bug/c-67-labels-in-widget-creation

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Fix Measure field in Add/Edit Report. The selection option was not being reflected in the UI.
  • Fix DimensionSelect.vue and TimeDimensionSelect.vue components by protecting .includes. In STG the app is breaking when some options are selected
  • Add missing translations

Screenshots (front-end changes only)

Screenshot 2022-11-15 at 18 27 50

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 15, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 7681b94
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/6373da835677500008885650

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 15, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 7681b94
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/6373da83a236d000082c0fc1

@joanagmaia joanagmaia self-assigned this Nov 15, 2022
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariobalca mariobalca merged commit 9f60cda into main Nov 16, 2022
@mariobalca mariobalca deleted the bug/c-67-labels-in-widget-creation branch November 16, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants