Reset dashboard after tenant selection#222
Merged
mariobalca merged 2 commits intomainfrom Nov 16, 2022
Merged
Conversation
❌ Deploy Preview for open-crowd-prod failed.
|
❌ Deploy Preview for open-devfounders failed.
|
joanagmaia
reviewed
Nov 16, 2022
| @@ -202,6 +202,10 @@ const taskCreatePermission = computed( | |||
| ) | |||
|
|
|||
| const storeUnsubscribe = store.subscribeAction((action) => { | |||
Contributor
There was a problem hiding this comment.
Sorry if I'm lacking context but should the tasks store be handled the same way as integrations? What I mean is that integrations are fetched from the start of the application regardless of opening the Integrations page. Once the tenant switches, the integrations are reset. Shouldn't it be the same for tasks?
Nonetheless, I think I found an issue with this approach which is the number of uncompleted tasks next to the "Tasks" menu item. After switching tenant, that value is only shown once you access the Tasks page. Could you please confirm if it's an issue? 🙏
mariobalca
deleted the
bug/c-98-reset-dashboard-after-tenant-selection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
Checklist ✅
type:feature 🚀,type:enhancement ✨,type:bug 🐞, ortype:documentation 📜.New backend functionality has been unit-tested.Environment variables have been updatedFront-end:frontend/.env.distBackend:backend/.env.dist,backend/.env.dist.staging,backend/.env.dist.staging.Configuration docs have been updated.Team members only: update environment variables in Password manager and update the teamAPI documentation has been updated (if necessary) (see docs on API documentation).