Skip to content

Fix merging members page#231

Merged
joanagmaia merged 3 commits intomainfrom
bug/merging-members
Nov 17, 2022
Merged

Fix merging members page#231
joanagmaia merged 3 commits intomainfrom
bug/merging-members

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Nov 17, 2022

Changes proposed ✍️

Task

  • Fix merge and ignore members suggestion action
    • Show toast messages for success and error
    • After request, fetch merge suggestions list again
    • Refactor loading states to reflect page status

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 17, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 20a39bb
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/63767ec9684733000964ff42

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 17, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 20a39bb
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/63767eca7121cc0008eacbe7

@joanagmaia joanagmaia merged commit 3f2516a into main Nov 17, 2022
@joanagmaia joanagmaia deleted the bug/merging-members branch November 17, 2022 18:36
joanagmaia added a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Mário Balça <mario.balca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants