Skip to content

Fix members export action#250

Merged
mariobalca merged 1 commit intomainfrom
bug/members-export-action
Nov 24, 2022
Merged

Fix members export action#250
mariobalca merged 1 commit intomainfrom
bug/members-export-action

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Remove filter from doFetch in doMarkAsTeamMember. It was not being used as the doFetch already uses the filters from the active view
  • Fix doExport action from member's actions by getting the filters from the active view. There is no state.filters, so this value was undefined and when used in the build-api-payload brook the app

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 24, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 2ac19dd
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/637f47e0c5a1f600099aa47f

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 24, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 2ac19dd
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/637f47e0677e1d0009c6020a

Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!
It reminded me that I have to do the same in the organization/actions.js
Nice work 🙌

@mariobalca mariobalca merged commit d09ffb5 into main Nov 24, 2022
@mariobalca mariobalca deleted the bug/members-export-action branch November 24, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants