Display markdown in activities#310
Merged
joanagmaia merged 2 commits intomainfrom Dec 6, 2022
Merged
Conversation
mariobalca
approved these changes
Dec 6, 2022
Contributor
mariobalca
left a comment
There was a problem hiding this comment.
Looks good to me!
The only thing that we need to keep in mind, but it's not a blocker to merge, is that by using a plugin, $marked won't be available to use within components built with the Composition API — we might need to create a component (with the Options API) just to render markdown with this new plugin (as well as the sanatize one).
Other that that, great job! Thanks for taking care of this 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
markedpackage to handle markdown parsingmarkedplugin to reuse the parse function globally throughout the componentsRelates to task
Relates to issue
Screenshots (front-end changes only)
Checklist ✅
Feature,Enhancement, orBug.frontend/.env.dist.local,frontend/.env.dist.composed.backend/.env.dist.local,backend/.env.dist.composed.