Skip to content

Fix dashboard evolutions#326

Merged
joanreyero merged 1 commit intomainfrom
bug/dashboard-evolutions
Dec 8, 2022
Merged

Fix dashboard evolutions#326
joanreyero merged 1 commit intomainfrom
bug/dashboard-evolutions

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Fix previousDateRange in dashboard-count.vue component. The request was being done with a wrong dateRange, where the most recent date was before the oldest one. To fix this, the order of the dates within the previousDateRange were switched. Since this component is global, this will fix the dashboard evolutions for all dashboard widgets

Screenshots

Screenshot 2022-12-07 at 19 18 41

Relates to #325

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Dec 7, 2022
@joanagmaia joanagmaia self-assigned this Dec 7, 2022
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 🙏
LGTM! 🚢 it

@joanreyero joanreyero merged commit 5d48924 into main Dec 8, 2022
@joanreyero joanreyero deleted the bug/dashboard-evolutions branch December 8, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants