Skip to content

feat: add fixtures for test tinybird pipes#3349

Merged
ulemons merged 17 commits intomainfrom
test/add-fixtures-for-local-tinybird
Sep 19, 2025
Merged

feat: add fixtures for test tinybird pipes#3349
ulemons merged 17 commits intomainfrom
test/add-fixtures-for-local-tinybird

Conversation

@ulemons
Copy link
Copy Markdown
Contributor

@ulemons ulemons commented Aug 26, 2025

Changes proposed ✍️

What

we want to test tinybird pipes locally.

How

Added docs for testing tinybird locally. Also fixtures were added:

  • activityRelations_deduplicated_cleaned_ds.ndjson
  • insightsProjects.ndjson
  • the cli uses the TB_HOST to connect to the local instance of tinybird
  • scaffold.insights.yaml is forced to use the classic tinybird version
  • in the configure-tinybird-sink.sh we are taking the token from the local tinybird instance
  • the tinybird-local-sink.properties is using the 7181 instead of the 80

-⚠️ remove fields from sequin.yml

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.

@ulemons ulemons self-assigned this Aug 26, 2025
@ulemons ulemons requested review from borfast and epipav as code owners August 26, 2025 14:29
@ulemons ulemons added the Improvement Created by Linear-GitHub Sync label Aug 26, 2025
Comment thread services/libs/tinybird/README.md Outdated
Copy link
Copy Markdown
Contributor

@borfast borfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 👏

I'm approving so this doesn't get blocked unnecessarily, but I'd love it if the instructions were slightly different, as I mentioned in the comment.

Copy link
Copy Markdown
Contributor

@borfast borfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect, thanks! It wasn't a required change, but thanks for doing it. 👍

I know it seems stupid, since the tokens are still recorded in a file, but it's about making this intentional and controlled, as opposed to incidental and uncontrolled exposure. The .env file is local only to the project, it's easier to delete, the tokens don't end up buried and forgotten in the middle of a ton of things, etc. It's a minor improvement but it's about following sound security principles. 🙂

Copy link
Copy Markdown
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ulemons ulemons force-pushed the test/add-fixtures-for-local-tinybird branch from 691e4d9 to a021a24 Compare September 15, 2025 08:31
@ulemons ulemons requested a review from gaspergrom as a code owner September 15, 2025 08:31
cursor[bot]

This comment was marked as outdated.

@ulemons ulemons force-pushed the test/add-fixtures-for-local-tinybird branch 2 times, most recently from 6221567 to 5d760ae Compare September 15, 2025 08:59
@ulemons ulemons force-pushed the test/add-fixtures-for-local-tinybird branch from 5d760ae to 5233296 Compare September 19, 2025 09:52
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@ulemons ulemons merged commit a79957d into main Sep 19, 2025
15 of 16 checks passed
@ulemons ulemons deleted the test/add-fixtures-for-local-tinybird branch September 19, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants