Skip to content

fix: kafka connection config in git integration v2#3377

Merged
mbani01 merged 2 commits into
mainfrom
fix/git_integration_v2
Sep 9, 2025
Merged

fix: kafka connection config in git integration v2#3377
mbani01 merged 2 commits into
mainfrom
fix/git_integration_v2

Conversation

@mbani01
Copy link
Copy Markdown
Contributor

@mbani01 mbani01 commented Sep 9, 2025

This pull request refactors the Kafka producer configuration in the QueueService to make it more flexible and secure. The main improvement is that Kafka connection parameters (including SSL and SASL settings) are now dynamically loaded from the CROWD_KAFKA_EXTRA environment variable, allowing easier configuration changes without code updates.

Kafka configuration improvements:

  • Refactored the initialization of the Kafka producer in QueueService to use a new _build_kafka_config method, which dynamically constructs the configuration based on the JSON in CROWD_KAFKA_EXTRA instead of hardcoding SASL/SSL parameters.
  • Added support for SSL connections by conditionally setting security_protocol and ssl_context based on the configuration, increasing security and flexibility.
  • Removed direct imports and usage of CROWD_KAFKA_USER and CROWD_KAFKA_PASSWORD in favor of extracting SASL credentials from the extra configuration, centralizing sensitive configuration management. [1] [2]

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@mbani01 mbani01 self-assigned this Sep 9, 2025
@mbani01 mbani01 added the Bug Created by Linear-GitHub Sync label Sep 9, 2025
@mbani01 mbani01 requested a review from epipav September 9, 2025 11:04
Copy link
Copy Markdown
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@mbani01 mbani01 merged commit 1ea37c9 into main Sep 9, 2025
12 checks passed
@mbani01 mbani01 deleted the fix/git_integration_v2 branch September 9, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants