fix: kafka connection config in git integration v2#3377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Kafka producer configuration in the
QueueServiceto make it more flexible and secure. The main improvement is that Kafka connection parameters (including SSL and SASL settings) are now dynamically loaded from theCROWD_KAFKA_EXTRAenvironment variable, allowing easier configuration changes without code updates.Kafka configuration improvements:
QueueServiceto use a new_build_kafka_configmethod, which dynamically constructs the configuration based on the JSON inCROWD_KAFKA_EXTRAinstead of hardcoding SASL/SSL parameters.security_protocolandssl_contextbased on the configuration, increasing security and flexibility.CROWD_KAFKA_USERandCROWD_KAFKA_PASSWORDin favor of extracting SASL credentials from the extra configuration, centralizing sensitive configuration management. [1] [2]Checklist ✅
Feature,Improvement, orBug.