chore: add new pipes to filter data by activity types for the Top LF projects widget [IN-707]#3451
Closed
borfast wants to merge 2 commits intofeat/IN-707-change-filtering-by-activity-typefrom
Closed
Conversation
Signed-off-by: Raúl Santos <4837+borfast@users.noreply.github.com>
Signed-off-by: Raúl Santos <4837+borfast@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
borfast
changed the title
gaspergrom
approved these changes
Oct 6, 2025
Contributor
gaspergrom
left a comment
gaspergrom
left a comment
There was a problem hiding this comment.
Best that also anil reviews
Contributor
Author
|
We decided to do this differently and filter on services/libs/tinybird/pipes/segmentId_aggregates_mv.pipe, which has the advantage that it covers other downstream pipes as well. The change was done here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #3432, to fix the problem mentioned there, of not being able to use activity types to filter data for the "Top LF projects" widget.
It adds a new copy pipe that is similar to
insightsProjects_filteredpipe but includes filtering for activity types, which we don't have on the former, and also uses some hard-coded filters for the Top LF projects widget to mimic the way the widget currently fetches data using dynamic filters.These have to be hard-coded because this is a copy pipe and thus, we can't use dynamic filtering.
These pipes and corresponding data source exist just for the aforementioned widget, because adding the activity type filtering to insightsProjects_filtered could have too much of a performance hit, and that pipe is used in a lot of other places, so we would negatively impact the whole application.