fix(git-integration): improve activity emission to kafka [CM-726]#3491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability and resource management of the Kafka queue integration in the
queue_service.pyand updates the repository worker to ensure proper shutdown. The main enhancements include adding robust connection retry logic, implementing a clean shutdown procedure, improving batch message sending, and making the disconnect logic safer.Reliability and Connection Handling Improvements
tenacitylibrary, with exponential backoff and limited retries, to make the service more resilient to transient connection failures. (queue_service.py) [1] [2]queue_service.py)Resource Management and Shutdown
shutdownmethod inQueueServicethat flushes pending messages, ensures the producer is stopped, and cleans up resources safely during application shutdown. The repository worker now calls this method to ensure a clean shutdown. (queue_service.py,repository_worker.py) [1] [2]disconnectmethod to safely handle repeated disconnect calls by checking if the producer is already closed, preventing unnecessary operations. (queue_service.py)Batch Message Sending Improvements
queue_service.py)