Skip to content

Posthog request proxy from frontend#358

Merged
epipav merged 1 commit intomainfrom
bugfix/proxy-posthog-requests
Dec 16, 2022
Merged

Posthog request proxy from frontend#358
epipav merged 1 commit intomainfrom
bugfix/proxy-posthog-requests

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Dec 16, 2022

Changes proposed ✍️

  • Direct posthog requests from frontend were blocked by browsers that run adblockers because of different domain. Now we're proxying posthog requests from our domain (https://ph.crowd.dev)
  • Also fixes a typo in eagle eye service that resulted in 403 errors instead of 400s

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav added the Bug Created by Linear-GitHub Sync label Dec 16, 2022
@epipav epipav self-assigned this Dec 16, 2022
@epipav epipav requested a review from joanagmaia December 16, 2022 12:25
@epipav epipav marked this pull request as ready for review December 16, 2022 12:38
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epipav epipav merged commit a0732b6 into main Dec 16, 2022
@epipav epipav deleted the bugfix/proxy-posthog-requests branch December 16, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants