Skip to content

Bots and team members excluded by default from cubejs#360

Merged
epipav merged 5 commits intomainfrom
improvement/cubejs-schema-changes
Jan 2, 2023
Merged

Bots and team members excluded by default from cubejs#360
epipav merged 5 commits intomainfrom
improvement/cubejs-schema-changes

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Dec 16, 2022

Changes proposed ✍️

  • Filters out team members and bots before returning data from cubejs. (Bot is specified as member.attributes->'isBot'->'default')
  • Sentiment cube is now joined with members as well, to be able to exclude team members.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav changed the title bot and team members excluded by default from results Bots and team members excluded by default from cubejs Dec 16, 2022
Comment thread frontend/src/modules/widget/components/cube/_query_builder/DimensionSelect.vue Outdated
@epipav epipav force-pushed the improvement/cubejs-schema-changes branch from 964130e to c167c87 Compare December 16, 2022 17:40
@epipav epipav self-assigned this Dec 16, 2022
@epipav epipav added the Improvement Created by Linear-GitHub Sync label Dec 16, 2022
@epipav epipav marked this pull request as ready for review December 16, 2022 17:53
@joanreyero joanreyero self-requested a review December 20, 2022 15:10
@epipav epipav merged commit c9ba76a into main Jan 2, 2023
@epipav epipav deleted the improvement/cubejs-schema-changes branch January 2, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants