Skip to content

fix: handle fkey constraint violations in organization merge with llm #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwowet merged 2 commits into from
Nov 13, 2025
Merged

fix: handle fkey constraint violations in organization merge with llm #3601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fc14e8
fix: handle fkey constraint violations in organization merge with llm
skwowet Nov 13, 2025
513ed15
fix: update logging for foreign key constraint violations in organiza…
skwowet Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions services/apps/merge_suggestions_worker/src/activities/organizationMergeSuggestions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,10 +498,22 @@ export async function removeOrganizationMergeSuggestions(

export async function addOrganizationSuggestionToNoMerge(suggestion: string[]): Promise<void> {
if (suggestion.length !== 2) {
svc.log.debug(`Suggestions array must have two ids!`)
svc.log.debug('Suggestions array must have exactly two ids!')
return
}

const qx = pgpQx(svc.postgres.writer.connection())

await addOrgNoMerge(qx, suggestion[0], suggestion[1])
try {
await addOrgNoMerge(qx, suggestion[0], suggestion[1])
} catch (error: unknown) {
// Handle foreign key constraint violation gracefully
if (error instanceof Error && 'code' in error && error.code === '23503') {
svc.log.info({ suggestion }, 'Foreign key constraint violation, skipping no merge!')
return
}

svc.log.error({ error, suggestion }, 'Error adding organization suggestion to no merge!')
throw error
Comment thread
skwowet marked this conversation as resolved.
}
}
Loading