feat: added the status field to all project related datasource and pipes#3746
Conversation
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
| ON insights_projects_populated_copy_mentions.projectSlug = insightsProjects.slug | ||
| LEFT JOIN | ||
| segments | ||
| ON segments.id = insightsProjects.segmentId |
There was a problem hiding this comment.
Missing FINAL on segments join inconsistent with file pattern
Medium Severity
The new LEFT JOIN segments lacks the FINAL keyword, inconsistent with all other ReplacingMergeTree table joins in this file (e.g., collectionsInsightsProjects FINAL, collections FINAL, integrations FINAL). The segments table uses ReplacingMergeTree with ENGINE_VER updatedAt. Without FINAL, unmerged updates could cause the join to return multiple rows per segment with different status values, producing duplicate project rows in the output.
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
| cast(coalesce(pp.memberActivityCount, 0) as Float64) as previousPeriodValue, | ||
| p.githubHandle as githubHandle | ||
| p.githubHandle as githubHandle, | ||
| '' as status |
There was a problem hiding this comment.
Column order mismatch in members leaderboard UNION
High Severity
The status field is added after githubHandle in leaderboards_members.pipe, but all other leaderboard pipes add status before githubHandle is appended by leaderboards_copy.pipe. In a UNION ALL, column position determines alignment, not names. This causes githubHandle values from members to be written to the status column and vice versa when combined with other leaderboards. The status field needs to be placed before githubHandle to match the column order of other pipes.
In this PR
Ticket
IN-887
Note
Adds project
statusacross Tinybird datasources and pipes for downstream consumers.insights_projects_populated_dsschema withstatus; populate viainsights_projects_populated_copy.pipe(LEFT JOINsegments)leaderboards_copy_dsschema and allleaderboards_*pipes to select/group/emitstatusstatusininsightsProjects_filtered,collections_listfeatured projects, andsearch_collections_projects_reposoutputsWritten by Cursor Bugbot for commit e654cfb. This will update automatically on new commits. Configure here.