Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
After user integrates with twitter, they can add hashtags to the integration. The timestamps generated by twitter follow activities are different if the integration is run with onboarding:true or onboarding:false.
Since these generate different sourceIds, in some cases when a scheduler(
onboarding:false) and reonboarding by user (onboarding:true) runs execute around same time, these runs may generate duplicate follow activities.With this pr integrations generate same twitter follow activity sourceIds hashes for different activity timestamps.
Additional script will be run against the database to update the obsolete sourceIds of follow activities.
Then using a SQL query, duplicate activities will be deleted, and member.joinedAt fields will be fixed.
Checklist ✅
type:feature 🚀,type:enhancement ✨,type:bug 🐞, ortype:documentation 📜.frontend/.env.distbackend/.env.dist,backend/.env.dist.staging,backend/.env.dist.staging.