Skip to content

Twitter follows duplicate activities bug#38

Merged
epipav merged 11 commits intomainfrom
bugfix/twitter-status-sourceId-duplicates
Sep 5, 2022
Merged

Twitter follows duplicate activities bug#38
epipav merged 11 commits intomainfrom
bugfix/twitter-status-sourceId-duplicates

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Sep 2, 2022

Changes proposed ✍️

After user integrates with twitter, they can add hashtags to the integration. The timestamps generated by twitter follow activities are different if the integration is run with onboarding:true or onboarding:false.
Since these generate different sourceIds, in some cases when a scheduler(onboarding:false) and reonboarding by user (onboarding:true) runs execute around same time, these runs may generate duplicate follow activities.

With this pr integrations generate same twitter follow activity sourceIds hashes for different activity timestamps.

Additional script will be run against the database to update the obsolete sourceIds of follow activities.
Then using a SQL query, duplicate activities will be deleted, and member.joinedAt fields will be fixed.

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav self-assigned this Sep 4, 2022
@epipav epipav requested a review from joanreyero September 5, 2022 10:15
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epipav epipav merged commit 7c5e571 into main Sep 5, 2022
@epipav epipav deleted the bugfix/twitter-status-sourceId-duplicates branch September 5, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants